-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
MaximeZmt
commented
Jun 2, 2022
•
edited
Loading
edited
…2022-Vibester into maximezmt/refactorsomexml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -104,6 +104,26 @@ class MyProfileFragmentTest { | |||
} | |||
|
|||
|
|||
@Test | |||
fun checkChangePhotoCancel() { | |||
val inputProfile = User( "Lalisa Bon","bit.ly/3IUnyAF", "[email protected]", 12, 8, "VvPB47tQCLdjz3YebilS6h5EXdJ3") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can use R.string.test_profile_image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean that field is useless now, still here for compatibility reasons. I don't think it is worth it to use context for that old field to retrieve a not used value 😅.
Code Climate has analyzed commit 8636d21 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 88.8% (80% is the threshold). This pull request will bring the total coverage in the repository to 83.4% (-0.5% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍