Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Better Xml #366

Merged
merged 12 commits into from
Jun 6, 2022
Merged

Better Xml #366

merged 12 commits into from
Jun 6, 2022

Conversation

MaximeZmt
Copy link
Owner

@MaximeZmt MaximeZmt commented Jun 2, 2022

photo_2022-06-03_01-06-52
Screenshot_20220606-164350_Vibester.jpg

@MaximeZmt MaximeZmt self-assigned this Jun 2, 2022
@MaximeZmt MaximeZmt marked this pull request as ready for review June 3, 2022 05:07
@jiabaow jiabaow self-requested a review June 6, 2022 17:41
Copy link
Collaborator

@jiabaow jiabaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -104,6 +104,26 @@ class MyProfileFragmentTest {
}


@Test
fun checkChangePhotoCancel() {
val inputProfile = User( "Lalisa Bon","bit.ly/3IUnyAF", "[email protected]", 12, 8, "VvPB47tQCLdjz3YebilS6h5EXdJ3")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can use R.string.test_profile_image

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean that field is useless now, still here for compatibility reasons. I don't think it is worth it to use context for that old field to retrieve a not used value 😅.

@codeclimate
Copy link

codeclimate bot commented Jun 6, 2022

Code Climate has analyzed commit 8636d21 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 88.8% (80% is the threshold).

This pull request will bring the total coverage in the repository to 83.4% (-0.5% change).

View more on Code Climate.

Copy link
Collaborator

@zwierski zwierski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MaximeZmt MaximeZmt merged commit 787b217 into main Jun 6, 2022
@MaximeZmt MaximeZmt deleted the maximezmt/refactorsomexml branch June 6, 2022 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants