Jwen/download songlist delete #357
Conversation
delete song on click
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| private val songList: ArrayList<String>, private val listener: OnItemClickListener? | ||
| ) : RecyclerView.Adapter<SongListAdapterForDelete.SongListForDeleteViewHolder>() { | ||
|
|
||
| override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): SongListForDeleteViewHolder { |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
|
|
||
| setContentView(R.layout.activity_download_manager) | ||
|
|
||
| Helper().setReturnToMainListener( |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
There was a problem hiding this comment.
I've tried the new feature on emulator.
Great Changes, but small remarks:
- Could be great to have something more meaningful than "-" like maybe a small bin
- Also when you click on the delete button, there is only the delete button that disappears but not the text. Could be great to remove the text too
Thanks for the remarks! |
|
Code Climate has analyzed commit 2fd5e91 and detected 7 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 98.2% (80% is the threshold). This pull request will bring the total coverage in the repository to 85.6% (0.0% change). View more on Code Climate. |
change the delete song activity to download manager
show the downloaded songs in recycler view with a delete button
for now:
After clicking the delete button, the button disappears, but the view of the song list will only be updated once we re-enter the activity.