Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

bugfix for offline game #356

Merged
merged 1 commit into from
May 27, 2022
Merged

Conversation

MaximeZmt
Copy link
Owner

@MaximeZmt MaximeZmt commented May 27, 2022

Bugs corrected with the offline game that was working only with internet connection. (Problem: was trying to fetch from online data (not song but metadata) API whereas explicited for offline version)

@MaximeZmt MaximeZmt marked this pull request as ready for review May 27, 2022 09:15
Copy link
Collaborator

@zwierski zwierski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on fixing this👍

Copy link
Collaborator

@jiabaow jiabaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaximeZmt MaximeZmt self-assigned this May 27, 2022
@codeclimate
Copy link

codeclimate bot commented May 27, 2022

Code Climate has analyzed commit 6b0ef25 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 54.5% (80% is the threshold).

This pull request will bring the total coverage in the repository to 86.2% (0.0% change).

View more on Code Climate.

@MaximeZmt MaximeZmt merged commit c582e3f into main May 27, 2022
@MaximeZmt MaximeZmt deleted the maximezmt/bugfixofflinegamewithoutinternet branch May 27, 2022 09:37
@MaximeZmt MaximeZmt changed the title bugfix bugfix for offline fame May 27, 2022
@MaximeZmt MaximeZmt changed the title bugfix for offline fame bugfix for offline game May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants