This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
game setup modification offline part 1 #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ester into maximezmt/offline
|
Code Climate has analyzed commit 96ea95c and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 95.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 85.1% (0.0% change). View more on Code Climate. |
MaximeZmt
changed the title
| fun returnFromGenreToGame(){ | ||
| fun internetButtonClick() { | ||
| InternetState.disableForceOnline() | ||
| onView(withId(R.id.game_setup_has_internet)).perform(click()) |
There was a problem hiding this comment.
Maybe you can add some empty lines between different logic in this test file
| viewfrag!!.findViewById<LinearLayout>(R.id.horilayer_single).visibility = VISIBLE | ||
| viewfrag!!.findViewById<TextView>(R.id.singleplayer_game_txt).visibility = VISIBLE | ||
| viewfrag!!.findViewById<TextView>(R.id.multiplayer_game_txt).visibility = VISIBLE | ||
|
|
There was a problem hiding this comment.
Again maybe add some empty lines for readability
laurislopata
approved these changes
May 25, 2022
jiabaow
approved these changes
May 25, 2022
| btn.text = getString(R.string.GameSetup_internetSwitchOff) | ||
| } else { | ||
| val isConncted = InternetState.getInternetStatus(requireContext()) | ||
| if(isConncted) { |
There was a problem hiding this comment.
Suggested change
| if(isConncted) { | |
| if (isConncted) { |
| @@ -59,7 +60,19 @@ class GameSetupFragmentTest { | |||
| } | |||
|
|
|||
| @Test | |||
| fun returnFromGenreToGame(){ | |||
| fun internetButtonClick() { | |||
| InternetState.disableForceOnline() | |||
There was a problem hiding this comment.
for the purpose of unit test, maybe separate online and offline
There was a problem hiding this comment.
This one is to check the transition, this is why it is like that
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit the game setup wether the user has internet or not.
Currently not connected to offline game but will come soon
