Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

show toast msg when no logged in #338

Merged
merged 9 commits into from
May 23, 2022
Merged

Conversation

jiabaow
Copy link
Collaborator

@jiabaow jiabaow commented May 22, 2022

No description provided.

@jiabaow jiabaow self-assigned this May 22, 2022
@jiabaow jiabaow linked an issue May 23, 2022 that may be closed by this pull request
@jiabaow jiabaow marked this pull request as ready for review May 23, 2022 18:04
@MaximeZmt MaximeZmt self-requested a review May 23, 2022 18:05
Copy link
Owner

@MaximeZmt MaximeZmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, LGTM 👍 two minor things below

Copy link
Owner

@MaximeZmt MaximeZmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jiabaow jiabaow requested a review from MaximeZmt May 23, 2022 18:16
Copy link
Collaborator

@kamilababayeva kamilababayeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loooks good! I have changed the string, let me know if you agree!

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented May 23, 2022

Code Climate has analyzed commit 8711916 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 80.6% (0.0% change).

View more on Code Climate.

@jiabaow jiabaow merged commit 689c777 into main May 23, 2022
@jiabaow jiabaow deleted the jwen/pop-up-when-no-logged-in branch May 23, 2022 19:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement pop-up when the user is not logged in. (#328)
3 participants