-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
add DataGetter() and FireBaseAuthenticator in constructor
turn search user to fragment
app/src/androidTest/java/ch/sdp/vibester/fragment/SearchUserFragmentTest.kt
Show resolved
Hide resolved
app/src/androidTest/java/ch/sdp/vibester/fragment/SearchUserFragmentTest.kt
Show resolved
Hide resolved
app/src/main/java/ch/sdp/vibester/user/ProfileFollowingAdapter.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, there are just a few minor readability comments I addressed. Other than that, the code looks perfect!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍 here are some comments
app/src/androidTest/java/ch/sdp/vibester/activity/profile/MyProfileActivityTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Code Climate has analyzed commit 1edb23f and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 89.4% (80% is the threshold). This pull request will bring the total coverage in the repository to 84.3%. View more on Code Climate. |
add the functionality to unfollow/refollow someone in search user and my profile.
all tested except firebase call