Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Jwen/unfollow #335

Merged
merged 27 commits into from
May 22, 2022
Merged

Jwen/unfollow #335

merged 27 commits into from
May 22, 2022

Conversation

jiabaow
Copy link
Collaborator

@jiabaow jiabaow commented May 21, 2022

add the functionality to unfollow/refollow someone in search user and my profile.
Screen Shot 2022-05-21 at 17 46 50

all tested except firebase call

@jiabaow jiabaow self-assigned this May 21, 2022
@jiabaow jiabaow marked this pull request as ready for review May 21, 2022 15:47
@zwierski zwierski self-requested a review May 21, 2022 18:33
turn search user to fragment
Copy link
Collaborator

@zwierski zwierski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there are just a few minor readability comments I addressed. Other than that, the code looks perfect!

@MaximeZmt MaximeZmt self-requested a review May 22, 2022 11:45
Copy link
Owner

@MaximeZmt MaximeZmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍 here are some comments

Copy link
Owner

@MaximeZmt MaximeZmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codeclimate
Copy link

codeclimate bot commented May 22, 2022

Code Climate has analyzed commit 1edb23f and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 89.4% (80% is the threshold).

This pull request will bring the total coverage in the repository to 84.3%.

View more on Code Climate.

@jiabaow jiabaow merged commit 6afa49a into main May 22, 2022
@jiabaow jiabaow deleted the jwen/unfollow branch May 22, 2022 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement unfollowing in search user, my profile and remove them in the database. (#320)
3 participants