Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Kamila/scoreboard fragment #311

Merged
merged 19 commits into from
May 20, 2022
Merged

Kamila/scoreboard fragment #311

merged 19 commits into from
May 20, 2022

Conversation

kamilababayeva
Copy link
Collaborator

@kamilababayeva kamilababayeva commented May 19, 2022

This PR convert Scoreboard Activity to Fragment

@kamilababayeva kamilababayeva marked this pull request as ready for review May 19, 2022 21:47
@kamilababayeva kamilababayeva self-assigned this May 19, 2022
@kamilababayeva kamilababayeva linked an issue May 19, 2022 that may be closed by this pull request
@MaximeZmt MaximeZmt self-requested a review May 19, 2022 21:48
Copy link
Owner

@MaximeZmt MaximeZmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor 👍 Just two comments below

Copy link
Collaborator

@zwierski zwierski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on refactoring! I left a comment (about the buttons) but it is not urgent: since it doesn't hinder the functionality, it can be addressed in a next sprint.

Copy link
Owner

@MaximeZmt MaximeZmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes, lgtm 😀👍

@codeclimate
Copy link

codeclimate bot commented May 20, 2022

Code Climate has analyzed commit 147126b and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 1

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 85.6% (0.0% change).

View more on Code Climate.

@kamilababayeva kamilababayeva merged commit cd66ca4 into main May 20, 2022
@kamilababayeva kamilababayeva deleted the kamila/scoreboard-fragment branch May 20, 2022 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set navigation button for scoreboard activity
3 participants