-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor 👍 Just two comments below
app/src/main/java/ch/sdp/vibester/fragment/ScoreBoardFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/ch/sdp/vibester/fragment/ScoreBoardFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/ch/sdp/vibester/fragment/ScoreBoardFragment.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on refactoring! I left a comment (about the buttons) but it is not urgent: since it doesn't hinder the functionality, it can be addressed in a next sprint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes, lgtm 😀👍
Code Climate has analyzed commit 147126b and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 85.6% (0.0% change). View more on Code Climate. |
This PR convert Scoreboard Activity to Fragment