Finishing up offline game #310
Conversation
|
|
||
| while(currentLine != null) { | ||
| while (currentLine != null) { |
There was a problem hiding this comment.
Good readability improvement
| var trimmed = currentLine.trim() | ||
| val split = trimmed.split(" - ") | ||
|
|
||
| if (split[0].trim().lowercase() == buttonSplit[0].trim().lowercase() |
There was a problem hiding this comment.
Maybe add some comments explaining what split[0] and split[1] are?
There was a problem hiding this comment.
Done, can you check if the explanations are clear?
… does it work on the CI
| @@ -125,6 +126,44 @@ class DeleteSongsActivity : AppCompatActivity() { | |||
| return false | |||
| } | |||
|
|
|||
| private fun removeFromProperties(buttonText: String): Boolean { | |||
There was a problem hiding this comment.
There is doc for all private function in this file. Maybe consider adding one line of javadoc for this one.
There was a problem hiding this comment.
Good catch! Changed it, committing soon!
app/src/main/res/values/strings.xml
Outdated
| <string name="game_setup_internet_switch_on">Internet is on</string> | ||
| <string name="game_setup_internet_switch_off">Internet is off</string> |
There was a problem hiding this comment.
As written in the wiki, consider using string name that respect string convention and put them at the top of the document in the corresponding part. (see here https://github.com/MaximeZmt/SDP_2022-Vibester/wiki)
Meaning
gameSetup_internetSwitchOn
gameSetup_internetSwitchOff
There was a problem hiding this comment.
Understood, will be in the next commit soon
|
Code Climate has analyzed commit e3f041a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 93.8% (80% is the threshold). This pull request will bring the total coverage in the repository to 85.5% (85.5% change). View more on Code Climate. |
Finishing up offline game from last week. Testing on the emulator works fine, need to write actual tests, and go over some of the past tests that may need some changes as well.