This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Kamila/remove create profile #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaximeZmt
reviewed
May 17, 2022
| import com.google.firebase.auth.GoogleAuthProvider | ||
| import com.google.firebase.auth.ktx.auth | ||
| import com.google.firebase.ktx.Firebase | ||
| import dagger.hilt.android.AndroidEntryPoint | ||
| import javax.inject.Inject | ||
|
|
||
| import net.datafaker.Faker |
There was a problem hiding this comment.
What is the purpose of DataFaker ?
There was a problem hiding this comment.
Is it to create fake username ?
There was a problem hiding this comment.
yes! I have a function that crates username with his library
| @@ -52,7 +53,7 @@ class DataGetter @Inject constructor() { | |||
| fun updateFieldInt(uid: String, fieldName: String, newVal: Int, method:String) { | |||
| dbUserRef.child(uid).child(fieldName) | |||
| .get().addOnSuccessListener { t -> | |||
| var finalVal = checkValue(t, method, newVal)//newVal TO DELETE IF TESTS PASS, OTHERWISE ROLL BACK! | |||
| val finalVal = checkValue(t, method, newVal)//newVal TO DELETE IF TESTS PASS, OTHERWISE ROLL BACK! | |||
There was a problem hiding this comment.
what is the purpose of this comment ? We should not keep it no ?
There was a problem hiding this comment.
It was not me who left it, i am not exaclty sure what it means... I will ask inva group
app/src/androidTest/java/ch/sdp/vibester/activity/AuthenticationActivityTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/ch/sdp/vibester/activity/AuthenticationActivityTest.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/ch/sdp/vibester/activity/AuthenticationActivity.kt
Outdated
Show resolved
Hide resolved
jiabaow
reviewed
May 17, 2022
|
Code Climate has analyzed commit a0b6218 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 73.5% (80% is the threshold). This pull request will bring the total coverage in the repository to 84.6%. View more on Code Climate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: