Upgrade of Profile_Activity Layout + image in search user activity #301
Conversation
MaximeZmt
changed the title
There was a problem hiding this comment.
Thanks for your pr! I have some suggestions, let me know if you can address them. Also, one of the idea I changed to relative layout was that the tests were failing. They fail now as well.
- For some reason, in my phone the button LogOut is too close to score stats. I have attached the picture below.
- If the username is too long, the button to edit and QR code disappears from the screen
- Maybe we should do these button static and not move based on username length
MaximeZmt
changed the title
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
|
||
| private fun setImage(imageURI: Uri) { | ||
| CoroutineScope(Dispatchers.Main).launch { | ||
| val task = async(Dispatchers.IO) { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| @@ -89,6 +90,9 @@ class ProfileActivity : AppCompatActivity() { | |||
| findViewById<ImageView>(R.id.avatar).setOnClickListener { | |||
| showGeneralDialog( "Do you want to change your profile picture?", false) | |||
| } | |||
| findViewById<CardView>(R.id.myCardView).setOnClickListener { | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
MaximeZmt
added
actual: 3h
| @@ -89,6 +90,9 @@ class ProfileActivity : AppCompatActivity() { | |||
| findViewById<ImageView>(R.id.avatar).setOnClickListener { | |||
| showGeneralDialog( "Do you want to change your profile picture?", false) | |||
| } | |||
| findViewById<CardView>(R.id.myCardView).setOnClickListener { | |||
| showGeneralDialog( "Do you want to change your profile picture?", false) | |||
| @@ -159,7 +164,8 @@ class ProfileActivity : AppCompatActivity() { | |||
| private fun setQrCodeToProfileBtnListener() { | |||
| findViewById<FloatingActionButton>(R.id.qrCode_returnToProfile).setOnClickListener { | |||
| setLayoutVisibility(findViewById<ConstraintLayout>(R.id.QrCodePage), false) | |||
| setLayoutVisibility(findViewById<RelativeLayout>(R.id.profileContent), true) | |||
| setLayoutVisibility(findViewById<ScrollView>(R.id.profileContent), true) | |||
| */ | ||
| private fun setImage(imageURI: Uri) { | ||
| CoroutineScope(Dispatchers.Main).launch { | ||
| val task = async(Dispatchers.IO) { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
| @@ -54,6 +55,9 @@ class MyProfileActivity : ProfileActivity() { | |||
| findViewById<ImageView>(R.id.avatar).setOnClickListener { | |||
| showGeneralDialog( "Do you want to change your profile picture?", false) | |||
| } | |||
| findViewById<CardView>(R.id.myCardView).setOnClickListener { | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit da08fed and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 79.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 83.9%. View more on Code Climate. |
Upgrade of Profile_Activity Layout: Fit better on any smartphone now
Update images loading to new version for Search User Activity