Refactor of intent fireing + LyricsBelongGameTest #268
Conversation
…DP_2022-Vibester into maximezmt/fireIntentRefactor
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -55,6 +56,10 @@ class DownloadActivity : AppCompatActivity() { | |||
| downloadListener(songNameView) | |||
| } | |||
|
|
|||
| findViewById<FloatingActionButton>(R.id.download_returnToMain).setOnClickListener { | |||
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| @@ -32,6 +33,10 @@ class DeleteSongsActivity : AppCompatActivity() { | |||
|
|
|||
| setContentView(R.layout.activity_delete_songs) | |||
|
|
|||
| findViewById<FloatingActionButton>(R.id.delete_returnToMain).setOnClickListener { | |||
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| @@ -30,6 +31,11 @@ class IncorrectSongsActivity : AppCompatActivity() { | |||
|
|
|||
| val layout: LinearLayout = findViewById(R.id.incorrect_songs_linear) | |||
|
|
|||
| findViewById<Button>(R.id.incorrect_songs_back_to_welcome) | |||
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| if(this::currentSong.isInitialized) { | ||
| return currentSong | ||
| } else { | ||
| return Song.songBuilder("http://example.com", "http://example.com", songName, artistName) |
There was a problem hiding this comment.
what is the purpose if this song.builder?
There was a problem hiding this comment.
The purpose of this song builder is that when the currentSong is not initialized yet (mean no web connection for instance/low connection), it does not crash and has song title and name
There was a problem hiding this comment.
I am not sure whether we should put a fake song. maybe we can put some text to screen. lets fix it next pr!
There was a problem hiding this comment.
this was not a fakesong. Just a fake url, but title and artist name is truth.
Indeed there is maybe another solution.
app/src/main/java/ch/sdp/vibester/activity/LyricsBelongGameActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/ch/sdp/vibester/activity/AuthenticationActivity.kt
Outdated
Show resolved
Hide resolved
|
Code Climate has analyzed commit ccc44b5 and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 88.3% (80% is the threshold). This pull request will bring the total coverage in the repository to 82.1%. View more on Code Climate. |
MaximeZmt
changed the title
Refactor of intent fireing + LyricsBelongGameTest