Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Refactor BuzzerSetupActivityTest & AuthenticationActivityTest #266

Merged
merged 3 commits into from
May 9, 2022

Conversation

MaximeZmt
Copy link
Owner

@MaximeZmt MaximeZmt commented May 8, 2022

Cleaning and refactoring some test
BuzzerSetupActivityTest & AuthenticationActivityTest
Running time improved in CI ~30sec to 1 min

@codeclimate
Copy link

codeclimate bot commented May 8, 2022

Code Climate has analyzed commit 451ac3d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 81.8% (0.0% change).

View more on Code Climate.

@MaximeZmt MaximeZmt changed the title refactor BuzzerSetupActivityTest Refactor BuzzerSetupActivityTest & AuthenticationActivityTest May 9, 2022
@MaximeZmt MaximeZmt added the actual: 1h actual time to fix label May 9, 2022
@MaximeZmt MaximeZmt marked this pull request as ready for review May 9, 2022 09:13
Copy link
Collaborator

@kamilababayeva kamilababayeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And, they have not reduces the coverage.... Awesome!

Copy link
Collaborator

@laurislopata laurislopata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! pretty short so not much to add

@MaximeZmt MaximeZmt merged commit 6a95b4b into main May 9, 2022
@MaximeZmt MaximeZmt deleted the maximezmt/refactorUnitTest branch May 9, 2022 09:54
@MaximeZmt MaximeZmt linked an issue May 9, 2022 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
actual: 1h actual time to fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework of Test: BuzzerActivity and Authentication
3 participants