This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Added change profile picture option #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -155,7 +198,7 @@ class ProfileActivity : AppCompatActivity() { | |||
| * @param textId id of the text in the dialog | |||
| * @param name of the dialog | |||
| */ | |||
| private fun showDialog(title: String, hint: String, id: Int, textId: Int, name: String) { | |||
| private fun showTextDialog(title: String, hint: String, id: Int, textId: Int, name: String) { | |||
There was a problem hiding this comment.
Method showTextDialog has 5 arguments (exceeds 4 allowed). Consider refactoring.
Tsathogguaa
reviewed
May 12, 2022
app/src/androidTest/java/ch/sdp/vibester/activity/ProfileActivityTest.kt
Outdated
Show resolved
Hide resolved
Tsathogguaa
reviewed
May 12, 2022
Tsathogguaa
reviewed
May 12, 2022
Tsathogguaa
reviewed
May 12, 2022
Tsathogguaa
reviewed
May 12, 2022
Tsathogguaa
reviewed
May 12, 2022
Tsathogguaa
reviewed
May 12, 2022
app/src/main/java/ch/sdp/vibester/user/UserScoreboardAdapter.kt
Outdated
Show resolved
Hide resolved
Tsathogguaa
reviewed
May 12, 2022
zwierski
reviewed
May 12, 2022
zwierski
reviewed
May 12, 2022
zwierski
reviewed
May 12, 2022
zwierski
reviewed
May 12, 2022
zwierski
reviewed
May 12, 2022
|
Code Climate has analyzed commit 73ac511 and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 42.5% (80% is the threshold). This pull request will bring the total coverage in the repository to 82.6% (-0.5% change). View more on Code Climate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.