margaux/typing game score #257
Conversation
|
Code Climate has analyzed commit 6963833 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 82.3% (0.0% change). View more on Code Climate. |
| @@ -223,6 +223,8 @@ class TypingGameActivity : GameActivity() { | |||
| findViewById<LinearLayout>(R.id.displayGuess).removeAllViews() | |||
| findViewById<EditText>(R.id.yourGuessET).text.clear() | |||
| findViewById<EditText>(R.id.yourGuessET).isEnabled = true | |||
| val score = gameManager.getCorrectSongs().size | |||
| findViewById<TextView>(R.id.playerScore).text = "@string/your_score_dot_dot $score" | |||
There was a problem hiding this comment.
it shows @string/your_score_dot_dot instead of "your score" when I tried it
I think having something else right after the score will look cluttered. Maybe 2 lines, one with the song number (in the game) on the top and one with the score underneath? not showing directly 3/5, just the idea of having the score and at which song the player is currently playing. |
| @@ -223,6 +223,8 @@ class TypingGameActivity : GameActivity() { | |||
| findViewById<LinearLayout>(R.id.displayGuess).removeAllViews() | |||
| findViewById<EditText>(R.id.yourGuessET).text.clear() | |||
| findViewById<EditText>(R.id.yourGuessET).isEnabled = true | |||
| val score = gameManager.getCorrectSongs().size | |||
| findViewById<TextView>(R.id.playerScore).text = "@string/your_score_dot_dot $score" | |||
There was a problem hiding this comment.
| findViewById<TextView>(R.id.playerScore).text = "@string/your_score_dot_dot $score" | |
| findViewById<TextView>(R.id.playerScore).text = "@string/your_score_dot_dot $score" |
Great changes 😃
Small comment:
- Can you change the string name according to the convention here [https://github.com/MaximeZmt/SDP_2022-Vibester/wiki] (We try to keep things ordered for new string like that 😉) It would be typingGame_yourScore (and can also change its place in the string.xml at the top of the file in the section if it exists or create TypingGame)
This PR updates the Typing Game by showing the player's current score on the game screen.