margaux/artwork-on-answer #256
Conversation
|
Code Climate has analyzed commit 2b4c6b8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 82.2% (0.0% change). View more on Code Climate. |
| class BuzzerScreenActivity : GameActivity() { | ||
|
|
||
| private val MAX_N_PLAYERS = 4 |
There was a problem hiding this comment.
Do we have no more limitations on the maximum number of players?
There was a problem hiding this comment.
No, the limitation to 4 players is still there, but this val was only used in a check before I figured out how to directly fetch the player names from the intent, so it's not useful anymore.
| findViewById<TextView>(R.id.answerText).text=title | ||
| val artist = gameManager.getCurrentSong().getArtistName() | ||
| findViewById<TextView>(R.id.songTitle).text= "$title - $artist" | ||
| Glide.with(ctx).load(gameManager.getCurrentSong().getArtworkUrl()).override(artworkDim, artworkDim).into(findViewById(R.id.songArtwork)) |
There was a problem hiding this comment.
Oh I have never heard of that Library. After having a look on internet, it may be great to use it everywhere. I will check later in my refactor if it is worth it or not.
| android:layout_marginStart="30dp" | ||
| android:layout_marginEnd="30dp" | ||
| android:background="#AAAAAA" | ||
| android:background="#DDDDDD" |
This PR adds, in the local buzzer game, the feature of the guessed song's album artwork being displayed on the answer card alongside the title.
Other minor adjustments were made, such as the artist's name appearing next to the title, and some UI adjustments on the size + color of the answer card.