This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Small refactoring and some documentation #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwierski
reviewed
May 5, 2022
| } | ||
| return finalVal | ||
| } | ||
|
|
There was a problem hiding this comment.
Good to have refactored that into a separate function, it avoids duplications and lengthy functions. 👍
zwierski
reviewed
May 5, 2022
| @@ -51,27 +53,18 @@ class GameEndingActivity : AppCompatActivity() { | |||
| } else {findViewById<TextView>(R.id.winnerText).text="Nobody won this game!"} | |||
| } | |||
|
|
|||
| getFromIntent(intent) | |||
There was a problem hiding this comment.
Good, much more readable than adding all the if's directly into the function.
zwierski
approved these changes
May 5, 2022
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| @@ -35,8 +38,12 @@ class LyricsBelongGameActivity : GameActivity() { | |||
| val getIntent = intent.extras | |||
| if (getIntent != null) { | |||
| gameManager = getIntent.getSerializable("gameManager") as GameManager | |||
| setNextButtonListener(ctx, gameManager) | |||
| setCheckButtonListener(ctx) | |||
| findViewById<Button>(R.id.nextSongButton).setOnClickListener { | |||
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
Code Climate has analyzed commit b2b538f and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 77.5% (80% is the threshold). This pull request will bring the total coverage in the repository to 83.9%. View more on Code Climate. |
laurislopata
approved these changes
May 5, 2022
Tsathogguaa
deleted the
tsathogguaa/documentation_and_possible_maintainability
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just took care of some maintainability issues in some files, and added a bit of documentation to some of the files that are missing them.