Jwen/customize game length #236
Conversation
| @@ -46,11 +45,27 @@ class GameSetupActivityTest { | |||
| Intents.release() | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Just a general comment for the file. It's more readable if you put empty lines between new logic. For example putting an empty line between "perform" statements and the actual test like "hasComponent" or "matches"
| "One" -> gameManager.setGameSize(1) | ||
| "Two" -> gameManager.setGameSize(2) | ||
| "Three" -> gameManager.setGameSize(3) | ||
| "Four" -> gameManager.setGameSize(4) | ||
| "Five" -> gameManager.setGameSize(5) | ||
| "Six" -> gameManager.setGameSize(6) | ||
| "Seven" -> gameManager.setGameSize(7) | ||
| "Eight" -> gameManager.setGameSize(8) | ||
| "Nine" -> gameManager.setGameSize(9) | ||
| "Ten" -> gameManager.setGameSize(10) |
There was a problem hiding this comment.
We may use string.xml for storing these. If one day we want to translate the app, it would be necessary to do it
| @@ -30,67 +29,85 @@ import retrofit2.Response | |||
| class GameSetupActivity : AppCompatActivity(), AdapterView.OnItemSelectedListener { | |||
| var difficulty = "Easy" | |||
| var game = "local_buzzer" | |||
| lateinit var gameManager: GameManager; | |||
| var gameSize = "One" | |||
| lateinit var gameManager: GameManager; | |||
There was a problem hiding this comment.
| lateinit var gameManager: GameManager; | |
| lateinit var gameManager: GameManager |
why a ";" ? we never used them in whole code
|
Code Climate has analyzed commit c6b07ed and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 67.3% (80% is the threshold). This pull request will bring the total coverage in the repository to 84.1% (-1.0% change). View more on Code Climate. |
No description provided.