Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

TypingGame: fix the double incrementaion of played songs #232

Merged
merged 5 commits into from
May 4, 2022

Conversation

kamilababayeva
Copy link
Collaborator

@kamilababayeva kamilababayeva commented May 3, 2022

This PR fixes:

  • number of played songs in TypingGame
  • Initialization of user in DataGetter

@codeclimate
Copy link

codeclimate bot commented May 3, 2022

Code Climate has analyzed commit 5666f0f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 90.9% (80% is the threshold).

This pull request will bring the total coverage in the repository to 85.9%.

View more on Code Climate.

@kamilababayeva kamilababayeva self-assigned this May 3, 2022
@kamilababayeva kamilababayeva linked an issue May 3, 2022 that may be closed by this pull request
@jiabaow jiabaow self-requested a review May 3, 2022 19:25
Copy link
Collaborator

@jiabaow jiabaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@MaximeZmt MaximeZmt self-requested a review May 4, 2022 10:48
Copy link
Owner

@MaximeZmt MaximeZmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice fix !

@kamilababayeva kamilababayeva merged commit bba638a into main May 4, 2022
@kamilababayeva kamilababayeva deleted the kamila/fix_typing_game branch May 4, 2022 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the bug in Typing Game: double incrementation of played songs
3 participants