Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Jwen/scoreboard UI fix #230

Merged
merged 4 commits into from
May 3, 2022
Merged

Jwen/scoreboard UI fix #230

merged 4 commits into from
May 3, 2022

Conversation

jiabaow
Copy link
Collaborator

@jiabaow jiabaow commented May 3, 2022

fix the bug in scoreboard ui where the 1st row doesn't show up.
Screen Shot 2022-05-03 at 10 20 09
Screen Shot 2022-05-03 at 10 20 18

@kamilababayeva
Copy link
Collaborator

Looks good! Thanks!

Comments for next pr:
The background in the choosing genre for scoreboard differs from other activities, it is whiter.
Also, maybe we can display scoreboard from the highest score to lowest?

@kamilababayeva kamilababayeva self-requested a review May 3, 2022 09:04
@jiabaow
Copy link
Collaborator Author

jiabaow commented May 3, 2022

Looks good! Thanks!

Comments for next pr: The background in the choosing genre for scoreboard differs from other activities, it is whiter. Also, maybe we can display scoreboard from the highest score to lowest?

Thanks for the feedback, I didn't notice the color, the scoreboard sorting can be done in another PR when retrieving real data from firebase per genre, this PR is only a UI fix.

Copy link
Collaborator

@laurislopata laurislopata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since it's pretty small not too much to comment

@codeclimate
Copy link

codeclimate bot commented May 3, 2022

Code Climate has analyzed commit 9239d66 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 85.8%.

View more on Code Climate.

@jiabaow jiabaow merged commit fc9d831 into main May 3, 2022
@jiabaow jiabaow deleted the jwen/scoreboard-ui-fix branch May 3, 2022 11:49
@jiabaow jiabaow linked an issue May 4, 2022 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUGFIX scoreboard display truncated
3 participants