Linking profile to image upload #228
Conversation
|
Code Climate has analyzed commit f9c9282 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 54.8% (80% is the threshold). This pull request will bring the total coverage in the repository to 84.0% (0.0% change). View more on Code Climate. |
|
|
||
| val scn: ActivityScenario<ProfileActivity> = ActivityScenario.launch(intent) | ||
|
|
||
| Thread.sleep(5000) |
There was a problem hiding this comment.
Why not use Completable Future to detect if images have been downloaded?
There was a problem hiding this comment.
Good idea, I'll implement it next week
|
|
||
| if(bm != null){ | ||
| val avatar = findViewById<ImageView>(R.id.avatar) | ||
| avatar.setImageBitmap(Bitmap.createScaledBitmap(bm, 1000,1000, false)) |
There was a problem hiding this comment.
maybe put 1000 in a meaningful val?
| val bit = BitmapGetterApi.download(imageURI.toString()) | ||
| bit.get(10, TimeUnit.SECONDS) | ||
| }catch (e: Exception){ | ||
| null |
There was a problem hiding this comment.
why the handle exception is null?
There was a problem hiding this comment.
@MaximeZmt wrote this function I just reused it, so maybe he can answer better :)
There was a problem hiding this comment.
It as was null because it was not a critical feature. I mean that the download of an image can fail for many reasons (user, server, Internet Provider, other users, ...)
Therefore if it does not works, As it was implemented at the beginning of the semester I've put null not knowing how to handle it.
Maybe there is a better way to do it now.
| * @param imageID ID of the image in the database | ||
| * @param callback function to be called when image fetched | ||
| */ | ||
|
|
| @@ -184,6 +185,10 @@ class DataGetter @Inject constructor() { | |||
| dbRoomRef.child(partyRoom.getRoomID()).child("emailList").setValue(partyRoom.getEmailList()) | |||
| } | |||
|
|
|||
| fun getCurrentUser(): FirebaseUser? { | |||
| return authenticator.getCurrUser() | |||
There was a problem hiding this comment.
why is it in dataFetter? We need to think of a separation between firebaseUser and Datagetter
Co-authored-by: Maxime <[email protected]>
Co-authored-by: Maxime <[email protected]>
Co-authored-by: Maxime <[email protected]>
Co-authored-by: Maxime <[email protected]>
Co-authored-by: Maxime <[email protected]>
Co-authored-by: jiabaow <[email protected]>
| @@ -207,6 +208,10 @@ class DataGetter @Inject constructor() { | |||
| dbRoomRef.child(partyRoom.getRoomID()).child("emailList").setValue(partyRoom.getEmailList()) | |||
| } | |||
|
|
|||
| fun getCurrentUser(): FirebaseUser? { | |||
There was a problem hiding this comment.
Reminder to add documentation for functions that are not private, no matter how obvious they can be. Not too important for this PR as we need a general check over our entire codebase and write docs, but a small reminder
This PR links the image upload from creating a user account to displaying it on the profile. This is a small PR but it took me longer than expected due to CI issues. The coverage is low because of database calls and image download functions so can't do much about it and it doesn't affect the overall coverage much