Jwen/qr code generator #227
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
|
|
||
| private fun showQrCode(boolean: Boolean) { | ||
| findViewById<ConstraintLayout>(R.id.profileContent).visibility = if (boolean) GONE else VISIBLE |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
|
||
| private fun showQrCode(boolean: Boolean) { | ||
| findViewById<ConstraintLayout>(R.id.profileContent).visibility = if (boolean) GONE else VISIBLE | ||
| findViewById<ConstraintLayout>(R.id.QrCodePage).visibility = if (boolean) VISIBLE else GONE |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
These are generated automatically by Android Studios to adapt to different use cases. I don't use them in this PR but I saw it is better to use mipmap to store the logo (https://stackoverflow.com/questions/28065267/mipmaps-vs-drawable-folders) which can be done in a separate PR. |
Okey, in that case LGTM |
Co-authored-by: Maxime <[email protected]>
Co-authored-by: Maxime <[email protected]>
|
Code Climate has analyzed commit f3dca7e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 96.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 85.6% (0.2% change). View more on Code Climate. |
ganerate qr code of the uid of user
