This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Kamila/set score game #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
jiabaow
reviewed
May 1, 2022
Co-authored-by: jiabaow <[email protected]>
Co-authored-by: jiabaow <[email protected]>
Co-authored-by: jiabaow <[email protected]>
| dbUserRef.child(uid).child(fieldName) | ||
| .get().addOnSuccessListener { t -> | ||
| var finalVal = newVal | ||
| if(t.value != null) { |
There was a problem hiding this comment.
Identical blocks of code found in 2 locations. Consider refactoring.
There was a problem hiding this comment.
Do you think it is worth spending time refactoring these two duplicate functions?
MaximeZmt
reviewed
May 2, 2022
app/src/androidTest/java/ch/sdp/vibester/activity/TypingGameActivityTest.kt
Outdated
Show resolved
Hide resolved
…tivityTest.kt Co-authored-by: Maxime <[email protected]>
Co-authored-by: Maxime <[email protected]>
Co-authored-by: Maxime <[email protected]>
|
Code Climate has analyzed commit 71b39aa and detected 8 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 44.1% (80% is the threshold). This pull request will bring the total coverage in the repository to 84.2% (0.1% change). View more on Code Climate. |
jiabaow
approved these changes
May 2, 2022
| dbUserRef.child(uid).child(fieldName) | ||
| .get().addOnSuccessListener { t -> | ||
| var finalVal = newVal | ||
| if(t.value != null) { |
There was a problem hiding this comment.
Do you think it is worth spending time refactoring these two duplicate functions?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the score after each typing game ended based on genre/mode.
Changes:
TODO next pr: save score per lyrics game, update UI