Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Kamila/fix friends double click #225

Merged
merged 31 commits into from
May 2, 2022
Merged

Conversation

kamilababayeva
Copy link
Collaborator

@kamilababayeva kamilababayeva commented Apr 30, 2022

This PR:

  • fix the double click to add "Users" in SearchUserActivity
  • do not display "Add" button if a user is already a friend
  • fixes in the user creation (add properly uid)
  • mock UserProfileAdapter, SearchUserActivity

TODO next pr: do not display authenticated user in the search, toast a message if non-authenticated user wants to follow someone

@kamilababayeva kamilababayeva self-assigned this May 1, 2022
@kamilababayeva kamilababayeva marked this pull request as ready for review May 1, 2022 20:21
@MaximeZmt MaximeZmt self-requested a review May 2, 2022 11:08
@jiabaow jiabaow self-requested a review May 2, 2022 11:15
Copy link
Owner

@MaximeZmt MaximeZmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, here are some comments 😀👍

Copy link
Owner

@MaximeZmt MaximeZmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@jiabaow jiabaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codeclimate
Copy link

codeclimate bot commented May 2, 2022

Code Climate has analyzed commit 9f46736 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 85.1% (80% is the threshold).

This pull request will bring the total coverage in the repository to 84.1%.

View more on Code Climate.

@kamilababayeva kamilababayeva merged commit f3b19e1 into main May 2, 2022
@kamilababayeva kamilababayeva deleted the kamila/fix_friends_double_click branch May 2, 2022 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants