Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

BUGFIX - fix some bugs #224

Merged
merged 6 commits into from
May 4, 2022
Merged

BUGFIX - fix some bugs #224

merged 6 commits into from
May 4, 2022

Conversation

MaximeZmt
Copy link
Owner

@MaximeZmt MaximeZmt commented Apr 29, 2022

Fixed Bugs

  • Unconnected user crash when finishing typing game
  • Not updating the user status when user click on android built-in return arrow to come back to welcome screen

@MaximeZmt MaximeZmt self-assigned this Apr 29, 2022
@MaximeZmt MaximeZmt changed the title BUGFIX - fix unconnected user crash BUGFIX - fix some bugs Apr 29, 2022
@MaximeZmt MaximeZmt marked this pull request as ready for review April 29, 2022 21:27
@MaximeZmt MaximeZmt linked an issue Apr 29, 2022 that may be closed by this pull request
Copy link
Collaborator

@kamilababayeva kamilababayeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! Nice fixes! I have left two comments, but otherwise all good!


Log.e("INFO: Should Access", ((InternetState.hasAccessedInternetOnce(this))).toString())
PersistanceSetter.setPersistance()
Database.get()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need Database.get() here if the result is not saved anywhere?

@jiabaow jiabaow self-requested a review April 30, 2022 09:43
Copy link
Collaborator

@jiabaow jiabaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeclimate
Copy link

codeclimate bot commented May 4, 2022

Code Climate has analyzed commit f9af34a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 85.1% (-0.8% change).

View more on Code Climate.

@MaximeZmt MaximeZmt merged commit ae02555 into main May 4, 2022
@MaximeZmt MaximeZmt deleted the maximezmt/bugfixlogin branch May 4, 2022 12:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUGFIX user not logged in crash in typing game
3 participants