Partial online multiplayer game implementation #204
Conversation
laurislopata
changed the title
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| private fun switchToRoom(roomName: String, createRoom: Boolean) { |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
|
Code Climate has analyzed commit 570bc7d and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 61.1% (80% is the threshold). This pull request will bring the total coverage in the repository to 85.3% (-1.2% change). View more on Code Climate. |
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="440dp" | ||
| android:ems="10" | ||
| android:hint="Party Name" |
There was a problem hiding this comment.
Hardcoded string here. It's fine overall, but please remember to fix it in your next PR
There was a problem hiding this comment.
Noted, I will fix it in the next PR
| import android.widget.Button | ||
| import android.widget.EditText | ||
| import ch.sdp.vibester.R | ||
|
|
There was a problem hiding this comment.
| /** | |
| * What is the purpose of the class ??? | |
| */ |
|
|
||
| @AndroidEntryPoint | ||
| class PartyRoomActivity : AppCompatActivity() { |
There was a problem hiding this comment.
| @AndroidEntryPoint | |
| class PartyRoomActivity : AppCompatActivity() { | |
| /** | |
| * What is class purpose | |
| */ | |
| @AndroidEntryPoint | |
| class PartyRoomActivity : AppCompatActivity() { |
|
|
||
| class PartyRoom() { |
There was a problem hiding this comment.
| class PartyRoom() { | |
| /** | |
| * DOCSSSS ? | |
| */ | |
| class PartyRoom() { |
|
|
||
|
|
|
Thank you for the comments, I'll add it in the next PR |
In this PR I started to implement the online buzzer game. For now, I synced up user connection to one party to demonstrate that it prints their emails on the screen. Will continue working on this next sprint