This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Kamila/remove handle #202
Merged
Kamila/remove handle #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have decided to remove handle from the user since it has the same meaning as the username. For uniqueness we use ID from the Firebase
jiabaow
reviewed
Apr 25, 2022
| @@ -48,16 +48,4 @@ class ScoreBoardActivityTest { | |||
| ) | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Why this test is removed? Does it relate to handle?
There was a problem hiding this comment.
The order of the users in the firebase is not deterministic. We have been deleting/adding users, so the user positions always change. I believe the removal of the test will not decrease any coverage of your changes
|
Code Climate has analyzed commit 842e7a1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 50.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 87.3%. View more on Code Climate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes user's handle from the code. Handle has the same meaning as username, so it is useless to have both entities. For later, we can enforce to have only username which will be unique.