Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

UserProfileAdapter: fix the image upload #201

Merged
merged 20 commits into from
Apr 26, 2022

Conversation

kamilababayeva
Copy link
Collaborator

@kamilababayeva kamilababayeva commented Apr 25, 2022

Changes:

  • fix the UID assign to user in Realtime database
  • fix the image upload in the user search
  • change the image view after the "Add" button was pressed
  • fix the friends' store in database
  • fix the profile_activity tests

image

@kamilababayeva kamilababayeva self-assigned this Apr 25, 2022
@kamilababayeva kamilababayeva linked an issue Apr 25, 2022 that may be closed by this pull request
@kamilababayeva kamilababayeva linked an issue Apr 25, 2022 that may be closed by this pull request
Copy link
Owner

@MaximeZmt MaximeZmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codeclimate
Copy link

codeclimate bot commented Apr 26, 2022

Code Climate has analyzed commit a2aa863 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 72.7% (80% is the threshold).

This pull request will bring the total coverage in the repository to 89.1% (1.6% change).

View more on Code Climate.

@jiabaow jiabaow self-requested a review April 26, 2022 10:30
Copy link
Collaborator

@jiabaow jiabaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
minor remark: Would you think it will be better to put the green tick in the center (aligned with the ADD)?

@kamilababayeva
Copy link
Collaborator Author

LGTM minor remark: Would you think it will be better to put the green tick in the center (aligned with the ADD)?

I will take a look at it in the next tasks on this user search! thanks!

@kamilababayeva kamilababayeva merged commit 325d971 into main Apr 26, 2022
@kamilababayeva kamilababayeva deleted the kamila/fix_image_load_friends branch April 26, 2022 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement and fixes of adding friend feature
3 participants