Kamila/add friends button #196
Conversation
app/src/main/java/ch/sdp/vibester/activity/SearchUserActivity.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks for the improvements!
I added a few comments and one first issue which should not be forgot:
Each time the build fails on e: /tmp/cirrus-ci-build/app/src/androidTest/java/ch/sdp/vibester/activity/SearchUserActivityTest.kt: (20, 32): Unresolved reference: UserProfile
e: /tmp/cirrus-ci-build/app/src/androidTest/java/ch/sdp/vibester/activity/SearchUserActivityTest.kt: (21, 32): Unresolved reference: UserProfileAdapter
| * @param searchInput search text inputed by user | ||
| * @param callback function to call with found users by username | ||
| * | ||
| * Comment about \uf8ff: |
There was a problem hiding this comment.
I suggest putting this comment right below line 89 so that when people read the code, it's easier for them to find the explanation.
| var ranking: Int = 0, | ||
| var uid: String = "" |
There was a problem hiding this comment.
why do we need an uid if the handle is already unique for each user?
There was a problem hiding this comment.
I was not sure whether the handle is correct. I saved the uid since the user is stored by it. We can discuss it next meeting.
| val extract = File("storage/emulated/0/Download", "extract_of_$songName") | ||
| assert(!extract.exists()) | ||
| } | ||
| // @Test |
There was a problem hiding this comment.
maybe explain in a comment why this test is commented
…y.kt Co-authored-by: Maxime <[email protected]>
thanks! fixed the issue with the build! |
|
Code Climate has analyzed commit e2c4361 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 75.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 86.3% (-1.2% change). View more on Code Climate. |
This PR contains a first basic version of adding friends.
Changes:
TODO: