Refactor Auth + Going forward score part 2 #190

MaximeZmt · 2022-04-19T21:30:39Z

Refactor Authentication Process + Updates Score into Firebase

This is related to issue #161

This Pull Requests contains:

Creation of user is fail safe. If the creation of user is successful, it will assign the user automatically to the linked part in the database. (before was needed another activity that if the user leave, it will block and loose it's account access)
Major refactor of google SignIn and LogIn: Now creates an account if first time log in, then manage as a normal user
Adding return Button in the game setup activity. Allow if missclick to return to the previous setting screen
Change the User UID, now uses the firebase auth UID before was using a random generated one -> much better for further dev in the app and easier
Added method in FireBaseAuthenticator to check account status and get information
Set Persistance of Database. It means that once the app has been open and loaded, as long as the user does not close it, even if he/she looses connection, the score will be still updated in the firebase as soon as he/she recover connection.
Has created method to update score in the database (set, relative update, best score)
Added a TestMode static class that helps to keep track in certain method whether is has been launched by unit test or not. (useful to bypass some verification like auth in unit test to test some button features, ...)

In addition the code is tested with a coverage of: [52.4]%

Notes for reviewers

see this article to try google sign in

codeclimate · 2022-04-27T08:10:14Z

app/src/main/java/ch/sdp/vibester/activity/AuthenticationActivity.kt

-                         createAcc: Boolean,
+
+//TODO
+    private fun startNewActivity(email: String) {


Similar blocks of code found in 2 locations. Consider refactoring.

jiabaow

review in progress

app/src/main/java/ch/sdp/vibester/TestMode.kt

app/src/main/java/ch/sdp/vibester/activity/AuthenticationActivity.kt

app/src/main/java/ch/sdp/vibester/api/InternetState.kt

app/src/main/java/ch/sdp/vibester/auth/FireBaseAuthenticator.kt

jiabaow · 2022-04-28T07:16:51Z

app/src/main/java/ch/sdp/vibester/auth/FireBaseAuthenticator.kt

+         * @param data intent returned from google sign in
+         */
+        fun googleActivityResult(requestCode: Int, resultCode: Int, data: Intent?, ctx: Context): String? {
+            if (requestCode == 1000) {


request code 1000 appears more than once in different files, it might be useful to store it as a const and give it an appropriate name.

app/src/main/java/ch/sdp/vibester/auth/FireBaseAuthenticator.kt

…ity.kt Co-authored-by: jiabaow <[email protected]>

Co-authored-by: jiabaow <[email protected]>

…ity.kt Co-authored-by: jiabaow <[email protected]>

Co-authored-by: jiabaow <[email protected]>

…022-Vibester into maximezmt/refactorauthp2

jiabaow

Thanks for this BIG refactoring/implementation.
As discussed, test coverage will be improved later.
What do you think of the idea of breaking down a huge PR into smaller PRs
and giving more meaningful commit messages?

app/src/main/java/ch/sdp/vibester/auth/FireBaseAuthenticator.kt

app/src/main/java/ch/sdp/vibester/database/DataGetter.kt

app/src/main/java/ch/sdp/vibester/database/Database.kt

app/src/main/java/ch/sdp/vibester/database/PersistanceSetter.kt

app/src/main/java/ch/sdp/vibester/helper/AllPurposeFunction.kt

kamilababayeva

I have left a partial review, I will look at your pr again after the changes. Lets do several PRs in next sprints, please!

But thank you a lot for your changes. They are nice!!

app/src/main/java/ch/sdp/vibester/activity/AuthenticationActivity.kt

app/src/main/java/ch/sdp/vibester/activity/CreateProfileActivity.kt

app/src/main/java/ch/sdp/vibester/database/DbUserIdStore.kt

app/src/main/java/ch/sdp/vibester/database/DataGetter.kt

app/src/main/java/ch/sdp/vibester/auth/FireBaseAuthenticator.kt

app/src/main/java/ch/sdp/vibester/api/InternetState.kt

app/src/androidTest/java/ch/sdp/vibester/UtilTest.kt

laurislopata · 2022-04-28T15:31:30Z

app/src/androidTest/java/ch/sdp/vibester/activity/LyricsBelongGameActivityTest.kt

@@ -17,12 +17,16 @@ import ch.sdp.vibester.R
 import ch.sdp.vibester.api.LastfmMethod
 import ch.sdp.vibester.helper.TypingGameManager
 import org.hamcrest.CoreMatchers.not
-import org.junit.*


Good change!

kamilababayeva

What causes such a drop in the tests coverage?

I gave it a second quick look, I have some questions. Next review I will approve, I promise!!!

app/src/androidTest/java/ch/sdp/vibester/activity/BuzzerScreenActivityTest.kt

app/src/androidTest/java/ch/sdp/vibester/activity/CreateProfileActivityTest.kt

app/src/androidTest/java/ch/sdp/vibester/activity/GameEndingActivityTest.kt

app/src/androidTest/java/ch/sdp/vibester/activity/WelcomeActivityTest.kt

app/src/androidTest/java/ch/sdp/vibester/auth/FireBaseAuthenticatorTest.kt

laurislopata · 2022-04-28T15:46:45Z

app/src/main/java/ch/sdp/vibester/api/InternetState.kt

+        private var hasAlreadyAccessedInternetOnce: Boolean = false
+        fun hasAccessedInternetOnce(ctx: Context):Boolean{
+            if (!hasAlreadyAccessedInternetOnce && getInternetStatus(ctx)) {
+


Extra unnecessary line

laurislopata

Good job!

app/src/main/java/ch/sdp/vibester/activity/WelcomeActivity.kt

kamilababayeva

Thank you for your work! The changes are nice and useful, you put a loooot of effort 💟 🎧

I hope we can separate big tasks in smaller tasks/prs next time. It is hard to check, and I believe it causes more errors/wrong decisions. go rest!

codeclimate · 2022-04-28T18:14:16Z

Code Climate has analyzed commit 8e559fc and detected 14 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	4
Duplication	10

The test coverage on the diff in this pull request is 52.4% (80% is the threshold).

This pull request will bring the total coverage in the repository to 85.4% (-3.6% change).

View more on Code Climate.

MaximeZmt added 2 commits April 19, 2022 23:28

update google signin auth

a629349

Merge branch 'main' of github.com:MaximeZmt/SDP_2022-Vibester into main

8c1f5ac

MaximeZmt self-assigned this Apr 19, 2022

MaximeZmt and others added 23 commits April 24, 2022 12:07

Merge branch 'main' into maximezmt/refactorauthp2

f264412

user profile improvement

2471a00

merged

ef91af0

test updates

3ba66aa

add persistance Setter

982f618

fixing test for idk numb of time

704fb09

fixing test for idk numb of time 2

a02c4bb

adding hilt to a test

4465122

fixing some other test

a8e0bdf

fixing some other test 2

42ef816

adding hilt to a test 2

cea160e

removing hilt typing

fc4a990

dumb modif

ee82439

removed hilt where it should not be

40277bd

Merge branch 'main' into maximezmt/refactorauthp2

e9a5c68

fix merging test error

de78a77

small update

93fffce

merged done

c13377c

patch profileActivityTest

9647fb1

patch profileActivityTest 2

e57a324

patch profileActivityTest 3

65e849e

massive user update

9f13f28

update tests

b8d646e

codeclimate bot reviewed Apr 27, 2022

View reviewed changes

MaximeZmt added 2 commits April 27, 2022 14:52

some improvements

c545546

put scores update for typing game

e0dcb23

MaximeZmt marked this pull request as ready for review April 27, 2022 13:37

jiabaow reviewed Apr 28, 2022

View reviewed changes

MaximeZmt and others added 11 commits April 28, 2022 09:25

Update app/src/main/java/ch/sdp/vibester/activity/AuthenticationActiv…

d498ddf

…ity.kt Co-authored-by: jiabaow <[email protected]>

Update app/src/main/java/ch/sdp/vibester/api/InternetState.kt

ffc2d11

Co-authored-by: jiabaow <[email protected]>

Update app/src/main/java/ch/sdp/vibester/api/InternetState.kt

d42d33a

Co-authored-by: jiabaow <[email protected]>

Update app/src/main/java/ch/sdp/vibester/activity/AuthenticationActiv…

56fbdd0

…ity.kt Co-authored-by: jiabaow <[email protected]>

Update app/src/main/java/ch/sdp/vibester/activity/GameEndingActivity.kt

2864d98

Co-authored-by: jiabaow <[email protected]>

Update app/src/main/java/ch/sdp/vibester/activity/ProfileActivity.kt

4402f27

Co-authored-by: jiabaow <[email protected]>

Update app/src/main/java/ch/sdp/vibester/activity/ProfileActivity.kt

19d6206

Co-authored-by: jiabaow <[email protected]>

Update app/src/main/java/ch/sdp/vibester/activity/ProfileActivity.kt

3d3b967

Co-authored-by: jiabaow <[email protected]>

review updated

74f41bd

Merge branch 'maximezmt/refactorauthp2' of github.com:MaximeZmt/SDP_2…

8f9b1fb

…022-Vibester into maximezmt/refactorauthp2

review updated 2

713f865

jiabaow reviewed Apr 28, 2022

View reviewed changes

kamilababayeva reviewed Apr 28, 2022

View reviewed changes

all issues addressed

e10f9c5

kamilababayeva self-requested a review April 28, 2022 15:23

kamilababayeva reviewed Apr 28, 2022

View reviewed changes

app/src/androidTest/java/ch/sdp/vibester/UtilTest.kt Outdated Show resolved Hide resolved

laurislopata reviewed Apr 28, 2022

View reviewed changes

kamilababayeva reviewed Apr 28, 2022

View reviewed changes

laurislopata reviewed Apr 28, 2022

View reviewed changes

laurislopata approved these changes Apr 28, 2022

View reviewed changes

MaximeZmt added 2 commits April 28, 2022 18:34

some other issues addressed

5b3c21f

renable a TestMode

ec89e32

kamilababayeva reviewed Apr 28, 2022

View reviewed changes

app/src/main/java/ch/sdp/vibester/activity/WelcomeActivity.kt Show resolved Hide resolved

kamilababayeva self-requested a review April 28, 2022 17:00

kamilababayeva approved these changes Apr 28, 2022

View reviewed changes

renable a TestMode 2

8e559fc

MaximeZmt merged commit 7916ffc into main Apr 28, 2022

MaximeZmt deleted the maximezmt/refactorauthp2 branch April 28, 2022 18:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor Auth + Going forward score part 2 #190

Refactor Auth + Going forward score part 2 #190

MaximeZmt commented Apr 19, 2022 •

edited

Loading

codeclimate bot Apr 27, 2022

jiabaow left a comment

jiabaow Apr 28, 2022

jiabaow left a comment

kamilababayeva left a comment •

edited

Loading

laurislopata Apr 28, 2022

kamilababayeva left a comment

laurislopata Apr 28, 2022

laurislopata left a comment

kamilababayeva left a comment

codeclimate bot commented Apr 28, 2022

Refactor Auth + Going forward score part 2 #190

Refactor Auth + Going forward score part 2 #190

Conversation

MaximeZmt commented Apr 19, 2022 • edited Loading

Refactor Authentication Process + Updates Score into Firebase

This is related to issue #161

Notes for reviewers

codeclimate bot Apr 27, 2022

Choose a reason for hiding this comment

jiabaow left a comment

Choose a reason for hiding this comment

jiabaow Apr 28, 2022

Choose a reason for hiding this comment

jiabaow left a comment

Choose a reason for hiding this comment

kamilababayeva left a comment • edited Loading

Choose a reason for hiding this comment

laurislopata Apr 28, 2022

Choose a reason for hiding this comment

kamilababayeva left a comment

Choose a reason for hiding this comment

laurislopata Apr 28, 2022

Choose a reason for hiding this comment

laurislopata left a comment

Choose a reason for hiding this comment

kamilababayeva left a comment

Choose a reason for hiding this comment

codeclimate bot commented Apr 28, 2022

MaximeZmt commented Apr 19, 2022 •

edited

Loading

kamilababayeva left a comment •

edited

Loading