This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Margaux/winner display #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 8a87248 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 88.5% (0.0% change). View more on Code Climate. |
kamilababayeva
approved these changes
Apr 19, 2022
jiabaow
approved these changes
Apr 19, 2022
| @@ -46,12 +47,9 @@ class GameEndingActivity : AppCompatActivity() { | |||
|
|
|||
| if (intent.hasExtra("Winner Name")) { | |||
| val winner = intent.getStringExtra("Winner Name") | |||
| // FIXME: commented until I get the winner panel to work without crashing the app | |||
| /* | |||
| if (winner!=null) { | |||
| findViewById<TextView>(R.id.winnerText).text="And the winner is... $winner!" | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the feature of displaying the winner's name at the end of a buzzer game, below the stats screen.