Laurislopata/upload image #184
Conversation
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
|
|
||
|
|
||
| private fun updateUI() { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
|
||
| // taskSnapshot.metadata contains file metadata such as size, content-type, etc. | ||
| uploadTask.addOnSuccessListener { taskSnapshot -> | ||
| callback() |
There was a problem hiding this comment.
I know you will add the task later but you can put everything in one line here since the callback() is short, it will not affect the readability.
There was a problem hiding this comment.
Agreed. Also, since testing these calls is hard, maybe consider concatenating some operations or lines.
There was a problem hiding this comment.
Also agreed, it's an easy way to make the coverage of external calls better.
|
|
||
| class Util { | ||
| companion object { | ||
| fun createNewId(): String { |
There was a problem hiding this comment.
consider adding documentation for this (explaining the form of the id, etc)
|
|
||
|
|
||
| private fun updateUI() { | ||
| findViewById<TextView>(R.id.uploadStatus).text = "Upload OK" |
There was a problem hiding this comment.
You can use strings.xml resources here instead of hardcoding. Let's keep it clean.
…-image' into laurislopata/upload-image
|
Code Climate has analyzed commit 5699a4d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 36.3% (80% is the threshold). This pull request will bring the total coverage in the repository to 87.6% (-0.9% change). View more on Code Climate. |
In this PR, I added a simple image selection and storage to firebase. Due to a lack of time this week I was unable to work more on it (connecting it with the user profile). I will finish that over the break as to why the coverage is low, these functions mainly use firebase and built-in activities like opening the default photos viewing app.