This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Kamila/add_user_search #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilababayeva
changed the title
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
app/src/main/java/ch/sdp/vibester/profile/UserProfileAdapter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/ch/sdp/vibester/activity/SearchUserActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/ch/sdp/vibester/activity/SearchUserActivity.kt
Outdated
Show resolved
Hide resolved
| userProfileAdapter = UserProfileAdapter(users!!) | ||
| recyclerView!!.adapter = userProfileAdapter | ||
| } | ||
| override fun onCancelled(error: DatabaseError) { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
This was
linked to
issues
Apr 17, 2022
app/src/main/java/ch/sdp/vibester/activity/SearchUserActivity.kt
Outdated
Show resolved
Hide resolved
MaximeZmt
suggested changes
Apr 17, 2022
laurislopata
approved these changes
Apr 17, 2022
|
Code Climate has analyzed commit 354458c and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 95.7% (80% is the threshold). This pull request will bring the total coverage in the repository to 88.8% (0.2% change). View more on Code Climate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains UI to search for users by their usernames. I have added the button on welcome screen, but we can move it later.
Changes:
The improvements can be: