Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Kamila/typing game disable guess #179

Merged
merged 4 commits into from
Apr 16, 2022
Merged

Kamila/typing game disable guess #179

merged 4 commits into from
Apr 16, 2022

Conversation

kamilababayeva
Copy link
Collaborator

@kamilababayeva kamilababayeva commented Apr 15, 2022 •
edited
Loading

This PR fixes small bug in Typing Game:

  • disable editting text after the round ends (before you were able to search for the song after the timer)
  • disable click on the songs after the round ends (before you were able to click on the song after the timer)
  • the timer fixed for the game

@kamilababayeva kamilababayeva self-assigned this Apr 15, 2022
@kamilababayeva kamilababayeva linked an issue Apr 15, 2022 that may be closed by this pull request
TypingGame: fix issues with timer, disable guess layout and edit text #164
Closed
@kamilababayeva kamilababayeva added the enhancement New feature or request label Apr 15, 2022
@codeclimate
Copy link

codeclimate bot commented Apr 15, 2022

Code Climate has analyzed commit 3d052db and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 88.2% (-0.2% change).

View more on Code Climate.

@MaximeZmt MaximeZmt marked this pull request as ready for review April 15, 2022 19:20
MaximeZmt
MaximeZmt approved these changes Apr 15, 2022
View reviewed changes
Copy link
Owner

@MaximeZmt MaximeZmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch for the correction of the timer! 😀👍

laurislopata
laurislopata approved these changes Apr 15, 2022
View reviewed changes
Copy link
Collaborator

@laurislopata laurislopata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to add since it's a short PR, good work on finding and fixing the code

@kamilababayeva kamilababayeva merged commit 5da7824 into main Apr 16, 2022
@kamilababayeva kamilababayeva deleted the kamila/typing_game_disable_guess branch April 16, 2022 05:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MaximeZmt MaximeZmt MaximeZmt approved these changes

@laurislopata laurislopata laurislopata approved these changes

Assignees

@kamilababayeva kamilababayeva

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypingGame: fix issues with timer, disable guess layout and edit text
3 participants
@kamilababayeva @laurislopata @MaximeZmt