Implemented downloading features #155
Conversation
|
|
||
| class DownloadActivity : AppCompatActivity() { |
There was a problem hiding this comment.
for all public methods of class (except override)
| fun switchToDownload(view: View) { | ||
| sendDirectIntent(DownloadActivity::class.java) | ||
| } | ||
|
|
There was a problem hiding this comment.
Should be easy to test, currently untested
| onView(withId(R.id.download_songName)).perform(typeText(songName), closeSoftKeyboard()) | ||
| Thread.sleep(100) | ||
| onView(withId(R.id.download_downloadsong)).perform(click()) | ||
| Thread.sleep(2000) |
There was a problem hiding this comment.
Try using constants for the Thread.sleep calls instead of hardcoded values.
| if(extract.exists()) { | ||
| assert(false) | ||
| } else { | ||
| assert(true) |
There was a problem hiding this comment.
Simpler to use assert(extract.exists()) here.
There was a problem hiding this comment.
Actually, for that one it's assert(!extract.exists()) due to it being a negative assumption. Otherwise you are correct, thanks!
|
Code Climate has analyzed commit 6c9bebf and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 83.9% (80% is the threshold). This pull request will bring the total coverage in the repository to 91.1% (-0.5% change). View more on Code Climate. |
Implemented the ability to download song extracts, acquired from the iTunes API.