Maximezmt/UI #124

MaximeZmt · 2022-03-29T18:46:52Z

Coherent UI

This is related to issue #116

This Pull Requests contains:

ch.sdp.vibester.activity: GameEndingActivity: Update UI
ch.sdp.vibester.activity: GameSetupActivity: Update UI + add submenu
ch.sdp.vibester.activity: GamescreenActivity: Update UI
ch.sdp.vibester.activity: IncorrectSongActivity: Update UI
ch.sdp.vibester.activity: ScoreboardActivity: Update UI
ch.sdp.vibester.activity: ProfileActivity: Update UI + Correct Image
ch.sdp.vibester.activity: SettingsActivity: Update UI
Readme: has been modified
Logo: Has been refactored

In addition the code is tested with a coverage of: [100]%

Notes for reviewers

NONE

jiabaow

LGTM

jiabaow · 2022-03-31T06:58:21Z

app/src/main/java/ch/sdp/vibester/activity/GameSetupActivity.kt

@@ -85,4 +95,15 @@ class GameSetupActivity : AppCompatActivity(), AdapterView.OnItemSelectedListene
        intent.putExtra("Player Names", pNameArray)
        startActivity(intent)
    }
+
+    private fun choosingGameSetupListener(){


Suggested change

private fun choosingGameSetupListener(){

private fun chooseGameSetupListener(){

jiabaow · 2022-03-31T07:00:14Z

app/src/main/java/ch/sdp/vibester/activity/ProfileActivity.kt

@@ -123,6 +135,15 @@ class ProfileActivity : AppCompatActivity() {
        findViewById<TextView>(R.id.ranking).text = user.ranking.toString()
        /* TODO: add functionality to display the image (may be using )


Suggested change

/* TODO: add functionality to display the image (may be using )

jiabaow · 2022-03-31T07:00:24Z

app/src/main/java/ch/sdp/vibester/activity/ProfileActivity.kt

@@ -123,6 +135,15 @@ class ProfileActivity : AppCompatActivity() {
        findViewById<TextView>(R.id.ranking).text = user.ranking.toString()
        /* TODO: add functionality to display the image (may be using )
        findViewById<ImageView>(R.id.avatar).loadImg(user.image)*/


Suggested change

findViewById<ImageView>(R.id.avatar).loadImg(user.image)*/

kamilababayeva

The app looks pretty now! Thank you for your work!

Github does not allow me to view all the changed files, so I will leave some small comments there. I think we can fix them in the next PR.

WelcomeActivity:button play music is not working and the app crashes. We need to remove switchToListen function from there.
GameSetupActivity: I liked it more when there was a small arrow in the dropdown for number of players. Now it is not clear if it is clickable or not.
[Question] is it okay that github build badge says failing?

kamilababayeva · 2022-03-31T06:32:03Z

app/src/main/java/ch/sdp/vibester/activity/ProfileActivity.kt

@@ -123,6 +135,15 @@ class ProfileActivity : AppCompatActivity() {
        findViewById<TextView>(R.id.ranking).text = user.ranking.toString()
        /* TODO: add functionality to display the image (may be using )
        findViewById<ImageView>(R.id.avatar).loadImg(user.image)*/


Can you remove these comment? thanks!

kamilababayeva · 2022-03-31T06:34:06Z

app/src/main/java/ch/sdp/vibester/activity/ProfileActivity.kt

+            val bm = task.await()
+            findViewById<ImageView>(R.id.avatar).setImageBitmap(bm)
+        }
+        findViewById<ImageView>(R.id.avatar).foregroundGravity= Gravity.LEFT


We have to do the same logic for loading images in the scoreboard. Right now, Glide library is used, but it is not working. I think it will take some time to redo, so lets leave it for future tasks.

yep, now the glide is failing:
W/Glide: Load failed for https://images.app.goo.gl/UpXEDTFLbcTL5mTJ8 with size [197x197]
class com.bumptech.glide.load.engine.GlideException: Failed to load resource
There were 8 root causes:
java.lang.RuntimeException(setDataSourceCallback failed: status = 0x80000000)
java.lang.RuntimeException(setDataSourceCallback failed: status = 0x80000000)

kamilababayeva · 2022-03-31T06:36:45Z

app/src/main/java/ch/sdp/vibester/activity/ProfileActivity.kt

+
+        requestWindowFeature(Window.FEATURE_NO_TITLE)
+        supportActionBar?.hide()
+


now these functions appear in most of the activities... do you think it would be better to do it from xml? Or maybe have one function that will be called in all these activities, or it would be too much?

I don't know if it is doable from the XML, maybe we should look for it next week :)

kamilababayeva · 2022-03-31T06:40:39Z

app/src/main/java/ch/sdp/vibester/activity/ProfileActivity.kt

+            val bm = task.await()
+            findViewById<ImageView>(R.id.avatar).setImageBitmap(bm)
+        }
+        findViewById<ImageView>(R.id.avatar).foregroundGravity= Gravity.LEFT


why dont you move Gravity stuff it to xml? is it possible?

yep will do it

kamilababayeva · 2022-03-31T06:43:46Z

README.md

+## Scrumboard & Weekly Meetings Logs <a name="devLogs"></a>
+
+- [Our Scrumboard](https://github.com/MaximeZmt/SDP_2022-Vibester/projects/1)
+- [Our Weekly Meeting](https://github.com/MaximeZmt/SDP_2022-Vibester/wiki)



Also in the beginning we can remove [To Complete: Abstract]

MaximeZmt · 2022-03-31T07:42:41Z

The app looks pretty now! Thank you for your work!

Github does not allow me to view all the changed files, so I will leave some small comments there. I think we can fix them in the next PR.

WelcomeActivity:button play music is not working and the app crashes. We need to remove switchToListen function from there. GameSetupActivity: I liked it more when there was a small arrow in the dropdown for number of players. Now it is not clear if it is clickable or not. [Question] is it okay that github build badge says failing?

Concerning the badges that fails, it is normal -> CI has failed and therefore it shows fail, just need a rebuild (would be done once merged)
Yes I will hide the button, I've keeped it temporarily if needed in the future
Yes I will see How I can change it :)

codeclimate · 2022-03-31T08:32:40Z

Code Climate has analyzed commit 0817172 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 91.3%.

View more on Code Climate.

MaximeZmt added 2 commits March 29, 2022 20:45

main remove enter + fields

090d59e

main remove enter + fields 2

a19dbac

MaximeZmt self-assigned this Mar 29, 2022

MaximeZmt linked an issue Mar 29, 2022 that may be closed by this pull request

Refactor main UI from the app + design logo (based on current draft) (#115) #116

Closed

MaximeZmt and others added 19 commits March 29, 2022 21:41

modification of gamescreen

6a6157f

updated ui +test

6491fd3

partial profile update

8630116

profile page user image fixed

334205c

updated test gamesetup scrollTo

b344691

fix 2 for gamesetup scrollTO

9f67425

fix 3 for gamesetup scrollTO

249b4a5

change scroll to constraint

fe95351

change scroll to constraint fix

c3fc953

update README

1967dd6

update README add space

d94435e

update README add space num 2

d2214f8

on the way of a clean readme

3426432

logo cleaner version

4ded593

update scoreboard color and readme

d852d3c

Merge branch 'main' into maximezmt/ui

d264604

remove duplicate background tint + fix

467d841

update layout ending screen

4095310

update settings activity

e4f8cd1

MaximeZmt marked this pull request as ready for review March 30, 2022 22:25

jiabaow approved these changes Mar 31, 2022

View reviewed changes

kamilababayeva approved these changes Mar 31, 2022

View reviewed changes

MaximeZmt added 2 commits March 31, 2022 10:00

correction pr

9685a1d

small xml profile update

0817172

MaximeZmt merged commit 4bc6aed into main Mar 31, 2022

MaximeZmt deleted the maximezmt/ui branch March 31, 2022 08:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Maximezmt/UI #124

Maximezmt/UI #124

MaximeZmt commented Mar 29, 2022 •

edited

Loading

jiabaow left a comment

jiabaow Mar 31, 2022

MaximeZmt Mar 31, 2022

jiabaow Mar 31, 2022

MaximeZmt Mar 31, 2022

jiabaow Mar 31, 2022

MaximeZmt Mar 31, 2022

kamilababayeva left a comment

kamilababayeva Mar 31, 2022

MaximeZmt Mar 31, 2022

kamilababayeva Mar 31, 2022

kamilababayeva Mar 31, 2022

MaximeZmt Mar 31, 2022

kamilababayeva Mar 31, 2022

MaximeZmt Mar 31, 2022

kamilababayeva Mar 31, 2022 •

edited

Loading

MaximeZmt Mar 31, 2022

kamilababayeva Mar 31, 2022

MaximeZmt Mar 31, 2022

MaximeZmt commented Mar 31, 2022

codeclimate bot commented Mar 31, 2022

	private fun choosingGameSetupListener(){
	private fun chooseGameSetupListener(){

		@@ -123,6 +135,15 @@ class ProfileActivity : AppCompatActivity() {
		findViewById<TextView>(R.id.ranking).text = user.ranking.toString()
		/* TODO: add functionality to display the image (may be using )


		requestWindowFeature(Window.FEATURE_NO_TITLE)
		supportActionBar?.hide()

Maximezmt/UI #124

Maximezmt/UI #124

Conversation

MaximeZmt commented Mar 29, 2022 • edited Loading

Coherent UI

This is related to issue #116

Notes for reviewers

jiabaow left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kamilababayeva left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kamilababayeva Mar 31, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MaximeZmt commented Mar 31, 2022

codeclimate bot commented Mar 31, 2022

MaximeZmt commented Mar 29, 2022 •

edited

Loading

kamilababayeva Mar 31, 2022 •

edited

Loading