Kamila/add ending screen #123
Conversation
|
Code Climate has analyzed commit ffac517 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 91.7% (0.5% change). View more on Code Climate. |
| object ServiceBuilder { | ||
| private fun buildRetrofit(baseUrl:String) = | ||
| Retrofit.Builder() | ||
| .baseUrl(baseUrl) | ||
| .addConverterFactory(GsonConverterFactory.create()) | ||
| .build() | ||
|
|
||
| fun <T> buildService(baseUrl: String, service: Class<T>): T { | ||
| /** | ||
| * Connect API interface to a retrofit service to make an API call. |
| intent.putStringArrayListExtra("str_arr_val", statVal) | ||
|
|
||
| startActivity(intent) | ||
| } |
There was a problem hiding this comment.
Maybe refactor the creations of the ArrayListand the calls to putStringArrayListExtra into a separate function? (Unless the values we will use instead of the hardcoded ones are of types other than String). The rest of the function looks good to me.
There was a problem hiding this comment.
True, maybe I will mode the creation of the arraylist with the delimeter '-' inside the gameManager.... I will taake a note for myself for the next pr. thanks!
This PR is related to #117.
This PR contains:
The code coverage is [100%]
