Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Kamila/change songlist structure #121

Merged
merged 3 commits into from
Mar 28, 2022

Conversation

kamilababayeva
Copy link
Collaborator

This PR is a feature request for internal use:

ch.sdp.vibester.model: SongList.kt: change structure array of string to array of Pair(String, String).

Appropriate files are change as well.

@codeclimate
Copy link

codeclimate bot commented Mar 28, 2022

Code Climate has analyzed commit a99a7b8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 66.6% (80% is the threshold).

This pull request will bring the total coverage in the repository to 92.6% (0.0% change).

View more on Code Climate.

@kamilababayeva kamilababayeva self-assigned this Mar 28, 2022
Copy link
Collaborator

@jiabaow jiabaow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Tsathogguaa Tsathogguaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kamilababayeva kamilababayeva merged commit 6ecc7e9 into main Mar 28, 2022
@kamilababayeva kamilababayeva deleted the kamila/change_songlist_structure branch March 28, 2022 21:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: change the songlist internal type to pair(string, string)
3 participants