Added database querying #106
Conversation
|
Code Climate has analyzed commit 5e8b60a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 90.4% (80% is the threshold). This pull request will bring the total coverage in the repository to 94.3% (-0.4% change). View more on Code Climate. |
|
I spent a lot of time looking into how the FireBase works and tried to make it work but for some reason it could not automatically convert the values to the UserProfile class that's why I had to do some "hacking" which doesn't look good and I will review it again over the weekend. Also the structure of our classes is not very good for quering databases as they are asynchronous (good explanation: https://stackoverflow.com/questions/47847694/how-to-return-datasnapshot-value-as-a-result-of-a-method/47853774), that's why for now I commented out unnecessary parts and fully refactor it next week. |
app/src/androidTest/java/ch/sdp/vibester/profile/ProfileDataProviderTest.kt
Show resolved
Hide resolved
| * @param requestCode a request code | ||
| * @param resultCode a result code | ||
| * @param data intent returned from google sign in | ||
| */ | ||
| fun googleActivityResult(requestCode: Int, resultCode: Int, data: Intent?): String? { | ||
| return if(requestCode == 1000) { | ||
| val task = GoogleSignIn.getSignedInAccountFromIntent(data) |
There was a problem hiding this comment.
Good documentation on this file.
| // } | ||
| // | ||
| //} |
There was a problem hiding this comment.
Maybe delete this file instead of commenting it if it won't be used anymore, unless the functions in it will be replaced by some other functions?
There was a problem hiding this comment.
Just in case, I left it here for now since I'll be doing the refactoring of our class structure for DB queries next week but I'll take note of your proposal :)
| * @param id id of the dialog | ||
| * @param textId id of the text in the dialog | ||
| */ | ||
|
|
There was a problem hiding this comment.
Careful in the Javadoc, title and hint are not parameters of the function. Does textId correspond to the "name" parameter?
|
Advices noted! |
No description provided.