This repository has been archived by the owner on Jan 31, 2024. It is now read-only.
Dynamic information passing for ArrayLists and Resource usage #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce usage in test classes in certain cases
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
As written in the codeclimate conversations, the duplicate code issue will be solved once we decide on a static array of stats, which will result in the removal of an ArrayList and thus, the duplicate code. |
MaximeZmt
approved these changes
Mar 24, 2022
app/src/main/java/ch/sdp/vibester/activity/IncorrectSongsActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/ch/sdp/vibester/activity/GameEndingActivity.kt
Outdated
Show resolved
Hide resolved
…asses involved in the PR.
|
Code Climate has analyzed commit fbf2ba3 and detected 5 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 94.7% (0.2% change). View more on Code Climate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved the issue with dynamic passage of arrays through intents from previous week. Also found and implemented a roundabout way of using resources such as ids and strings in test cases.