Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Jwen/lyrics belong #102

Merged
merged 11 commits into from
Mar 24, 2022
Merged

Jwen/lyrics belong #102

merged 11 commits into from
Mar 24, 2022

Conversation

jiabaow
Copy link
Collaborator

@jiabaow jiabaow commented Mar 23, 2022

Screen Shot 2022-03-24 at 16 31 38

@jiabaow jiabaow self-assigned this Mar 24, 2022
@jiabaow
Copy link
Collaborator Author

jiabaow commented Mar 24, 2022

As you all know, I haven’t found a way to test it. 🥲
I will leave the test class like this for now, and either come up with a solution or clean it up for next week.

Copy link
Collaborator

@Tsathogguaa Tsathogguaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Let's keep in mind to test what we weren't able to, if we find a solution. Otherwise no need to worry!

Copy link
Owner

@MaximeZmt MaximeZmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work (just missing small doc) but approved 👍


private const val REQUEST_AUDIO = 100

class LyricsBelongGameActivity : AppCompatActivity() {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could add some doc for function/class! What does the class represent ?

@codeclimate
Copy link

codeclimate bot commented Mar 24, 2022

Code Climate has analyzed commit 5c00063 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 75.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 92.9% (-1.7% change).

View more on Code Climate.

@MaximeZmt MaximeZmt merged commit 6089689 into main Mar 24, 2022
@MaximeZmt MaximeZmt deleted the jwen/lyrics-belong branch March 24, 2022 22:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create an activity that recognizes what the player sings and tells if the lyrics belong to a given song. (#97)
3 participants