Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: add small tick hits #49

Merged
merged 2 commits into from
Nov 29, 2024
Merged

refactor!: add small tick hits #49

merged 2 commits into from
Nov 29, 2024

Conversation

MaxOhn
Copy link
Owner

@MaxOhn MaxOhn commented Nov 29, 2024

If users use the osu! api they're provided score statistics containing slider tail hits and small tick hits. Instead of requiring users to check for themselves which one of the two they need to pass to the slider_tail_hits method, there is now a small_tick_hits methods so rosu_pp can pick the correct value automatically.

There's also breaking changes:

  • OsuPerformance::n_large_ticks has been renamed to large_tick_hits
  • OsuPerformance::n_slider_ends has been renamed to slider_end_hits
  • Performance::n_slider_ends has been renamed to slider_end_hits
  • OsuScoreState has an additional field small_tick_hits
  • ScoreState has an additional field osu_small_tick_hits
  • OsuScoreState is no longer Copy

@MaxOhn MaxOhn merged commit cb9877a into main Nov 29, 2024
5 checks passed
@MaxOhn MaxOhn deleted the small-tick-hits branch November 29, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant