Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async is supported #1

Merged
merged 5 commits into from
Feb 23, 2021
Merged

Async is supported #1

merged 5 commits into from
Feb 23, 2021

Conversation

Pure-Peace
Copy link
Contributor

PR - rosu-pp v0.1.2

  • Suppot asynchronous beatmap file reading and parsing (based on async-std).
  • New features "async_std" (optional).
  • Add an asynchronous wrapper for calculate(): calculate_async().
  • Add asynchronous testing.
  • README.md added async examples.
  • Change the version number to 0.1.2.
  • Added async keywords in Cargo.toml

@MaxOhn
Copy link
Owner

MaxOhn commented Feb 23, 2021

Thanks for the PR!
Looks pretty good. I think the code duplication can be reduced a little through some #[cfg]s but I'll look into it.
Merging it right up :)

FYI I want to keep the main branch in sync with the version on crates.io so the new stuff goes into the next branch but you couldn't know that so no condemning here.

@MaxOhn MaxOhn merged commit 6c32f11 into MaxOhn:main Feb 23, 2021
@Pure-Peace
Copy link
Contributor Author

Oh, I agree with you. Really good project! :D

@MaxOhn
Copy link
Owner

MaxOhn commented Feb 23, 2021

Small update:

I removed the calculate_async pp methods since they don't benefit from asynchronocity and if people need them async they can just wrap them in an async { ... }.await.

Async map parsing is super worth it though so that was a great addition.
Also added an async_tokio feature so there's an option between async_std and tokio runtimes.

I'll let it run in some application for a few days to check if everything's working fine and then publish it as v0.2.0. 😃

@Pure-Peace
Copy link
Contributor Author

❤️Nice!

7mochi pushed a commit to osuperu/rosu-pp_old that referenced this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants