New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PP calculation with certain mod combinations #3

Merged

MaxOhn merged 3 commits into MaxOhn:main from tsunyoku:fix-mod-calculation

Jul 16, 2022

Contributor

tsunyoku commented Jul 16, 2022

Python bindings were specifying accuracy before mods, which caused things to break internally and provide incorrect values. This PR fixes this bug.

tsunyoku added 3 commits

July 16, 2022 19:58


          specify mods before acc

0862c10


          fix ownership of calculator

dbf6b20


          v0.7.2

16c587b

MaxOhn merged commit d84a7d8 into MaxOhn:main

Owner

MaxOhn commented Jul 16, 2022

Thanks for the PR!
For future reference, I prefer handling the versioning myself so that should've been excluded but that's alright :)

tsunyoku deleted the fix-mod-calculation branch

July 16, 2022 19:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet