impl(lazy-initialize): set content for handlePrint() and handleClick() via second optional argument using [content]

[isocroft]

Fixes #652

[MatthewHerbst]

Thanks! Will take a look at this later this evening

[isocroft]

Hello @MatthewHerbst , i was hoping to get some feedback on this as soon as you can be available say this weekend ?

[MatthewHerbst]

Hi, apologies, have been slammed with work. Promise to review this within the next 48 hours

[MatthewHerbst]

Looks good, just curious if there's a way to simplify the logic at all maybe?

[isocroft]

Hello. @MatthewHerbst , I am done with the change requests you mandated based on your review.

Thanks a lot 🙏🏾

[MatthewHerbst]

Looks great! One last request: can we make the example much, much shorter? The examples for the other uses are about 25 lines each, and don't reference any random external dependencies. Can we make the added example similarly short, and remove any reference to external dependencies that most readers of the README will not be familiar with?

[isocroft]

Ok @MatthewHerbst , I will do just that.

Thanks

[isocroft]

All done now @MatthewHerbst 👍🏾

[MatthewHerbst]

Ah, realized one last thing! Otherwise looks fantastic, and thank you so much for adding the examples!

[MatthewHerbst]

Nice! Happy with this! Two small nits before we merge

[isocroft]

Hello @MatthewHerbst , all done here

[MatthewHerbst]

Published in v2.15.0!

[Bowbaq]

This seems to break existing code by adding this new mandatory event argument, which doesn't appear to be used for anything.

> tsc && vite build

src/components/print-table/index.tsx:23:5 - error TS2554: Expected 1-2 arguments, but got 0.

23     handlePrint();
       ~~~~~~~~~~~~~

  node_modules/react-to-print/lib/hooks/useReactToPrint.d.ts:3:35
    3 type UseReactToPrintHookReturn = (event: unknown, content?: (() => React.ReactInstance | null)) => void;
                                        ~~~~~~~~~~~~~~
    An argument for 'event' was not provided.


Found 1 error in src/components/print-table/index.tsx:23

[MatthewHerbst]

This seems to break existing code by adding this new mandatory event argument, which doesn't appear to be used for anything.

> tsc && vite build

src/components/print-table/index.tsx:23:5 - error TS2554: Expected 1-2 arguments, but got 0.

23     handlePrint();
       ~~~~~~~~~~~~~

  node_modules/react-to-print/lib/hooks/useReactToPrint.d.ts:3:35
    3 type UseReactToPrintHookReturn = (event: unknown, content?: (() => React.ReactInstance | null)) => void;
                                        ~~~~~~~~~~~~~~
    An argument for 'event' was not provided.


Found 1 error in src/components/print-table/index.tsx:23

Ah crap, you're totally right, this should be optional. Will push out a fix now

[MatthewHerbst]

@Bowbaq fix published in v2.15.1, please let me know if you run into any additional issues, and thank you so much for the report!