hidpp10_constants.py: Remove dependency to NamedInts #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move validators into their own module. - Convert Kind to IntEnum Related pwr-Solaar#2273
Classes shouldn't don't need to know about other settings classes. Related pwr-Solaar#2273
Enforce create_widgets and collect_values. Related pwr-Solaar#2273
Refactor code related to task and task ID. Related pwr-Solaar#2273
Related pwr-Solaar#2273
The key flags are solely used in hiddpp20 module, thus put them into the module. Related pwr-Solaar#2273
Related pwr-Solaar#2273
This data is not in use currently. Related pwr-Solaar#2273
The mapping flags are solely used in hiddpp20 module, thus put them into this module. Related pwr-Solaar#2273
The charge status is solely used in the hiddpp20 module, thus put it into this module. Related pwr-Solaar#2273
Ensure behavior stays the same. Related pwr-Solaar#2273
|
I'll try to rebase it all on top of the latest Solaar version and merge in my master. Then we can tackle the remaining left overs which can be tricky. |
MattHag
force-pushed
the
refactor_settings
branch
2 times, most recently
from
fc3e16f to
93a6aca
Compare
MattHag
force-pushed
the
refactor_settings
branch
from
28e5566 to
4b3524d
Compare
|
Cherry-picked them in my pull request. Thanks |
MattHag
reviewed
Dec 21, 2024
| @@ -55,7 +55,23 @@ | |||
|
|
|||
| FixedBytes5 = bytes | |||
|
|
|||
| KIND_MAP = {kind: hidpp10_constants.DEVICE_KIND[str(kind)] for kind in DEVICE_KIND} | |||
| HIDPP10_DEVICE_KIND = NamedInts( | |||
There was a problem hiding this comment.
@rloutrel Can you avoid this? It just reintroduces the NamedInts in another place.
MattHag
force-pushed
the
refactor_settings
branch
6 times, most recently
from
4a8f2a9 to
e3bdd63
Compare
MattHag
force-pushed
the
refactor_settings
branch
from
e3bdd63 to
5333e0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be easier to merge it now than later