Skip to content

Commit

Permalink
Hotfix 1.10 - Now starts in Gnome 3.34
Browse files Browse the repository at this point in the history
Fixes This fixes refer to [Issue #2](#2).

 Changes to be committed:
	new file:   CHANGELOG.md
	modified:   extension.js
  • Loading branch information
MattByName committed Nov 25, 2019
2 parents b1e95f8 + 7b27847 commit a78863b
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 8 deletions.
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# 1.1.0

## Fixes
This fixes refer to [Issue #2](https://github.com/MattByName/color-tint/issues/2)

- 'Slider.setValue' no longer works. Replaced with 'Slider.value ='. See also [this issue](https://github.com/martin31821/cpupower/pull/90) on someone else's project
- No signal value-changed error also fixed. Replaced with 'notify::value'. See also [this issue](https://github.com/aleho/gnome-shell-volume-mixer/commit/5ec18540eaa53345d545cef6dfd343d4a8b0db55) on someone else's project

# 1.0.0
- Made changes requested by extension team
16 changes: 8 additions & 8 deletions extension.js
Original file line number Diff line number Diff line change
Expand Up @@ -195,20 +195,20 @@ const MenuButton = new Lang.Class({
this._alphaSliderContainer.actor.add(this._alphaSlider.actor, {expand: true});
this.menu.addMenuItem(this._alphaSliderContainer);

this._redSlider.connect('value-changed', Lang.bind(this, this._setColors));
this._blueSlider.connect('value-changed', Lang.bind(this, this._setColors));
this._greenSlider.connect('value-changed', Lang.bind(this, this._setColors));
this._alphaSlider.connect('value-changed', Lang.bind(this, this._setColors));
this._redSlider.connect('notify::value', Lang.bind(this, this._setColors));
this._blueSlider.connect('notify::value', Lang.bind(this, this._setColors));
this._greenSlider.connect('notify::value', Lang.bind(this, this._setColors));
this._alphaSlider.connect('notify::value', Lang.bind(this, this._setColors));

this._getColors();


},
_getColors: function () {
this._redSlider.setValue(overlay_color["red"] / 255);
this._greenSlider.setValue(overlay_color["green"] / 255);
this._blueSlider.setValue(overlay_color["blue"] / 255);
this._alphaSlider.setValue(overlay_color["alpha"] / 255);
this._redSlider.value = overlay_color["red"] / 255;
this._greenSlider.value = overlay_color["green"] / 255;
this._blueSlider.value = overlay_color["blue"] / 255;
this._alphaSlider.value = overlay_color["alpha"] / 255;
},
_setColors: function () {
overlay_color["red"] = 255 * this._redSlider._getCurrentValue();
Expand Down

0 comments on commit a78863b

Please sign in to comment.