fix: streams created by peers must initiate with an Ack message

MatrixAI · Sep 8, 2023 · 8889a59 · 8889a59
1 parent 916cea6
commit 8889a59
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/src/WebSocketConnection.ts b/src/WebSocketConnection.ts
@@ -196,11 +196,7 @@ class WebSocketConnection {
 
     let stream = this.streamMap.get(streamId);
     if (stream == null) {
-      const messageType = remainder.at(0);
-      if (
-        messageType === StreamMessageType.Close ||
-        messageType === StreamMessageType.Error
-      ) {
+      if (remainder.at(0) !== StreamMessageType.Ack) {
         return;
       }
       stream = await WebSocketStream.createWebSocketStream({

diff --git a/tests/WebSocketStream.test.ts b/tests/WebSocketStream.test.ts
@@ -53,10 +53,7 @@ jest.mock('@/WebSocketConnection', () => {
       let stream = instance.connectedConnection!.streamMap.get(streamId);
       if (stream == null) {
         const type = remainder.at(0);
-        if (
-          type === StreamMessageType.Close ||
-          type === StreamMessageType.Error
-        ) {
+        if (type !== StreamMessageType.Ack) {
           return;
         }
         stream = await WebSocketStream.createWebSocketStream({