-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand pkStdio
, pkExec
and pkSpawn
utils to target executables
#410
Comments
This is to be used with the pkg integration tests to test the docker, windows and mac executables. Related #410
pkSpawn(args, env, cwd, logger);
// becomes
pkSpawnSwitch(global.testCmd)(args, env, cwd, logger); |
And ultimately the Would it be possible that the test code automatically specifies the |
I think @emmacasolin had a way to check what platform was when tests were running. I'll have to dig through the |
These return either the pkX or the pkXTarget command if the `cmd` is set. Related #410
I think you should keep the entrypoint functions the same name as before. It should be just But internally switch to a different implementation. You can do this like: function pkExec() {
if (...) { return pkExecTarget(); }
// ... original functionality ...
}
function pkExecTarget() {
// new functionality
} |
This is to be used with the pkg integration tests to test the docker, windows and mac executables. Related #410
These return either the pkX or the pkXTarget command if the `cmd` is set. Related #410
This is to be used with the pkg integration tests to test the docker, windows and mac executables. Related #410
These return either the pkX or the pkXTarget command if the `cmd` is set. Related #410
`DOCKER_OPTIONS` env variable containing all the docker run parameters to make the test work is provided to the command. #410
…time The `runTestIfPlatform` commands will default to running if `PK_TEST_PLATFORM` is not set. #410
`DOCKER_OPTIONS` env variable containing all the docker run parameters to make the test work is provided to the command. #410
…time The `runTestIfPlatform` commands will default to running if `PK_TEST_PLATFORM` is not set. #410
Specification
We need to expand the
pkStdio
,pkExec
, andpkSpawn
utility commands to support testing executable files such as the win, mac builds and docker container. Counterparts to these commands need to be created. These new commands need to mimic their counterparts but execute the target executable.Additional context
Tasks
pkExecTarget
pkStdioTarget
- this can't work with mocking so keep that in mind.pkSpawnTarget
pk
command or it's counterpart to execute the command.The text was updated successfully, but these errors were encountered: