Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix For Rust 180 #1

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fix For Rust 180 #1

merged 1 commit into from
Aug 7, 2024

Conversation

abezukor
Copy link
Collaborator

@abezukor abezukor commented Aug 6, 2024

Fixes a crash in debug builds caused by rust-lang/rust#124210. This was due to the CBL2CAPChannel closing the stream file descriptor on close, so we should not also do it again when the tokio::net::UnixStream is dropped.

Copy link

@anubhavm11 anubhavm11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on the app, logic makes sense. Please merge this so that I can start building on master.

@abezukor
Copy link
Collaborator Author

abezukor commented Aug 7, 2024

Works on the app, logic makes sense. Please merge this so that I can start building on master.

PR Approval?

@abezukor abezukor merged commit bd061c1 into main Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants