-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System`Element typos #830
System`Element typos #830
Conversation
mathics/autoload/rules/Element.m
Outdated
(*General Algebraic*) | ||
|
||
Element[z:(_Plus|_Times), domine:(Booleans|Integers|Rationals|Reals|Complexes|Algebraics)]:=Element[Alternatives@@z, domine]; | ||
Element[_Times, Primes]:=Element[Alternatives@@z, Primes]; | ||
Element[z:(_Plus|_Times), domine:(Integers|Rationals|Reals|Complexes|Algebraics)]:=Element[Alternatives@@z, domine]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is "domine" a misspelling of "domain"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! Fixed now
mathics/autoload/rules/Element.m
Outdated
@@ -89,15 +89,12 @@ | |||
Element[True|False|E|EulerGamma|Khinchin|MachinePrecision|Pi, Algebraics]:=False; | |||
Element[z_DirectedInfinity, domine:(Booleans|Integers|Rationals|Reals|Complexes)]:=False; | |||
Element[z_Power, Integers]:= (Element[Alternatives@@z, Integers] && z[[2]]>=0); | |||
Element[z_Power/;Element[Alternatives@@z, ], Integers]:= (z[[2]]>=0); | |||
Element[z_Power/;Element[Alternatives@@z, Integers], Integers]:= (Print["OK"];z[[2]]>=0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this "Print["OK"]" supposed to be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not it doesn't. Removed now.
LGTM - thanks for the fixes. |
This PR just fixes a couple of typos in the
Element.m
autoload module